11/2/2022 0 Comments Roboform extension firefox
Roboform extension firefox update#Enabled and got pop-up to update to 7.6.3 Presumably not supported in this FF version but there was no mention of that during installation Tried to reproduce with Windows 7 圆4 but with no luck. If that does not crash, then I will be out of ideas on whether my fix really helps or not. I guess I will generate a dummy build based on but without my fix to see if that crashes. But the above makes me doubt whether the fix is really working, or whether the issue is being bypassed because of some unknown reason. This should be equivalent to the current 8.0.1 candidate builds with my fix on top. Firefox does not crash at startup with this build. Firefox does not crash at startup with this build, but this doesn't tell us anything since the previous build doesn't crash ( comment 81) is a *PGO* build *with* my fix. Firefox does not crash at startup with this build, which surprises me, because I expect that it is a *non-PGO* build *with* my fix. So, I tried the builds and I'm really puzzled at this is a *non-PGO* build *without* my fix. This makes me very worried about any version-specific blocklist perhaps causing this failure mode. Now this is still a little broken, but I basically see in the assembly that in some cases GetFileVersionInfoSizeW itself calls LoadLibraryEx. > xul.dll!patched_LdrLoadDll(wchar_t * filePath, unsigned long * flags, _UNICODE_STRING * moduleFileName, void * * handle) + 0x42486 + 0x32 + 0x31 bytes Xul.dll!patched_LdrLoadDll(wchar_t * filePath, unsigned long * flags, _UNICODE_STRING * moduleFileName, void * * handle) + 0x42486 + 0x32 + 0x31 bytes Without fsecure the stack loop is pretty straightforward: Xul.dll!patched_LdrLoadDll(wchar_t * filePath, unsigned long * flags, _UNICODE_STRING * moduleFileName, void * * handle) + 0x42486 bytesĜ++ Do we know if this crash only happens with F-secure installed also?īelow here the stack is unreliable, but it may involve a loop of these + 0xc + 0xc + 0x31 bytes Roboform extension firefox code#I just got off 12 hours of air travel and 4 days of jetlag, and the thought of me in the code review path of a release is terrifying right now so let's go through this list again and be extra sure, please.įirefox appears to be crashing with a stack overflow exception:įirst-chance exception at 0x7c90e8e5 (ntdll.dll) in firefox.exe: 0xC00000FD: Stack + 0xaf + 0x31624 + 0x9b48 + 0x93 + 0x1c + 0x27 + 0x1f + 0x17d + 0x1cb + 0x18 + 0x22e bytesįshook32 is part of F-Secure. Still, someone should double check my math, BECAUSE: Roboform extension firefox Patch#h file) on FF8, but Kev's patch on FF9 and up. By my reckoning that makes Nick right, and we'd want his patch (against the. cpp in bug 648581, which landed September 19. TIL that Ehsan moved the blocklist from a. Roboform extension firefox how to#We don't seem quite clear yet on whether our blocklist.xml tests have affirmatively ruled out that option, there's back and forth in this bug about how to test it - we should be sure I'd normally insert a thing about how we don't typically DLL blocklist extensions since they can be blocked with the addon blocklist which is more user-friendly, but from the sounds of it RoboForm might be hacking around that Marcia uses "7.5.2.0" in comment 2 and this patch uses 7.6.2.0 - is that deliberate? (Judging from the rest of comment 2 I'd assume she just typo'd, but let's be sure) I haven't tested it so that would need to happen before we landed/shipped it Roboform dll block for toolkit/xre/nsWindowsDllBlocklist.cpp
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |